search

simc / logger

Small, easy to use and extensible logger which prints beautiful logs.
https://pub.dev/packages/logger
MIT License
1.07k stars 129 forks source link

Updated the library to follow good practices on library organization, added compatibility with browser #14

Closed marcgraub closed 4 years ago

marcgraub commented 4 years ago

Hi! Newbie here.

First of all, thank you for your awesome projects.

Trying to use your project on a webapp, I've seen that it is incompatible with browser projects. The reason is the file file_output.dart being dependant on the library dart:io. In this pull request I've added file_output.dart as a conditional export.

More info Sass example of conditional export

Also, I've updated the project to follow the advice on the official docs on creating libraries:

Note: You may have heard of the part directive, which allows you to split a library into multiple Dart files. We recommend that you avoid using part and create mini libraries instead.

I've followed the sass project as example.

Sorry if something is wrong and thank you for your work.

haarts commented 4 years ago

Not that I have anything to say about this repo, but since I am reading the code anyway... :)

haarts commented 4 years ago

The build fails. I think it has smt to do with the formatting. Can you run dartfmt against your branch?

haarts commented 4 years ago

@marcgraub I've agreed with @leisim that I'll be helping out with the maintenance of this package. Could you resolve the merge conflict, then I'll merge your contribution. After that I'll spent some time on the on the 5th of Nov.

haarts commented 4 years ago

I've gone ahead and fixed the minor merge conflict myself. Thanks for your contribution!