search

simc / logger

Small, easy to use and extensible logger which prints beautiful logs.
https://pub.dev/packages/logger
MIT License
1.07k stars 129 forks source link

Allow formatting without decorative box using printBox parameter #85

Closed IanWorthington closed 3 years ago

IanWorthington commented 3 years ago

I've modified the pretty printer to make the decorative box optional.

If this is of any use, please feel free to add it in to the base!

IanWorthington commented 3 years ago

This was reformatted with Android Studio 4.1.2. Might your dartfmt give different output?

haarts commented 3 years ago

The dart formatter indeed gives a different output. dart fmt is the formatter the project uses.

On Sat, Mar 13, 2021, 19:56 IanWorthington @.***> wrote:

This was reformatted with Android Studio 4.1.2. Might your dartfmt give different output?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/leisim/logger/pull/85#issuecomment-798767386, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACTJCJV4CK2TJHZSF3UFTTDOYMNANCNFSM4ZECUNIQ .

IanWorthington commented 3 years ago

The dart formatter indeed gives a different output. dart fmt is the formatter the project uses.

Hi! I'm sorry, but I'm rather confused. According to https://dart.dev/tools/dart-format:

Use the dart format command to replace the whitespace in your program with formatting that follows Dart guidelines. This is the same formatting that you can get when using an IDE or editor that has Dart support.

What reformatter does this project use, and where can I get it from?

IanWorthington commented 3 years ago

Found a small error in FileOuput so I've pushed the fix for that as well.

It still fails the dartfmt test though and I've no idea how to fix that, sorry. But if you let me know I'll do it.

IanWorthington commented 3 years ago

I don't know how to fix this and I need to push unrelated commits now, and as I have no idea of how to stop those being added to this PR I'm closing this.

Feel free to pull the code and use it if you wish.