simd-everywhere / simde

Implementations of SIMD instruction sets for systems which don't natively support them.
https://simd-everywhere.github.io/blog/
MIT License
2.38k stars 247 forks source link

NEON: implement all intrinsics supported by architecture A64-part1 #1090

Closed yyctw closed 1 year ago

yyctw commented 1 year ago

Hi all, this is Eric from Andes Technology Corporation. This PR is part of the previous PR and includes the following: Add 368 initial implementations and corresponding test cases in 88 families which are listed below:

mr-c commented 1 year ago

The build error for "Windows MSVC-Aarch64" reminds me of this note in the .appveyor.yml.

https://github.com/simd-everywhere/simde/blob/029d7498974eb43fe98b0341ca1dd269ca70d12c/.appveyor.yml#L99

So maybe try replacing https://github.com/simd-everywhere/simde/blob/029d7498974eb43fe98b0341ca1dd269ca70d12c/.github/workflows/ci.yml#L662 with ninja -C build test

yyctw commented 1 year ago

Quick fix for the native-aliases build failure

It has been fixed.

yyctw commented 1 year ago

Initial review of the 1st 50 files; I'll review the next batch when these comments are resolved.

@mr-c I have addressed all the comments. My apologies for inadvertently deleting and adding the Copyright. Thank you for your review!

yyctw commented 1 year ago

1st 75 files reviewed. Some errant copyright statements still.

Thank you for including the test generation code!

Already fixed.

mr-c commented 1 year ago

Really impressive, thank you @yyctw !

https://github.com/simd-everywhere/implementation-status/commit/71ae00c429075ea0e07644e408fa6f2281d17956 !!!