search

simd-everywhere / simde

Implementations of SIMD instruction sets for systems which don't natively support them.
https://simd-everywhere.github.io/blog/
MIT License
2.32k stars 239 forks source link

apply arm64 windows workaround only on older version msvc #1121

Closed Changqing-JING closed 7 months ago

Changqing-JING commented 8 months ago

The arm_neo.h bug of msvc is fixed. So that the workaround is not needed on new msvc

Changqing-JING commented 8 months ago

@mr-c why can emscripten test fail on this PR? This PR should not be related to emscripten

mr-c commented 8 months ago

@mr-c why can emscripten test fail on this PR? This PR should not be related to emscripten

The emscripten tests use the latest "tip-of-tree" build of emcc/clang to catch issues early. So it wasn't your change, but their change. Next we need to see if the stable emsdk version also fails, and if not, to switch to that from the "tot" version. Simultaneously we should file an issue with the emscripten people

mr-c commented 8 months ago

This might be the cause, so hopefully we can try again when the fix is released

https://github.com/emscripten-core/emscripten/issues/21026