search

simd-everywhere / simde

Implementations of SIMD instruction sets for systems which don't natively support them.
https://simd-everywhere.github.io/blog/
MIT License
2.28k stars 237 forks source link

README.md - move CLMUL to partial, list more of the CI.yml architectures #1170

Closed Torinde closed 3 months ago

Torinde commented 4 months ago

Per https://github.com/simd-everywhere/simde/pull/1152#issuecomment-2021047051

Should the following two architectures also be added?

mr-c commented 4 months ago

That's correct, it isn't currently under any test

  • z/Architecture ZVECTOR - it's in simde-features.h, but ci.yml just lists s390x, so unclear if ZVECTOR extensions are utilized

Looking at .github/workflows/ci.yml https://github.com/simd-everywhere/simde/blob/517da845ac83098d06c5b0c9d8705ac8eb32a5ba/.github/workflows/ci.yml#L411-L414

which gets combined with https://github.com/simd-everywhere/simde/blob/517da845ac83098d06c5b0c9d8705ac8eb32a5ba/.github/workflows/ci.yml#L452

Therefore we check https://github.com/simd-everywhere/simde/blob/master/docker/cross-files/s390x-gcc-12-ccache.cross and find https://github.com/simd-everywhere/simde/blob/517da845ac83098d06c5b0c9d8705ac8eb32a5ba/docker/cross-files/s390x-gcc-12-ccache.cross#L11-L12

So yes, s390x with zvector is tested in CI ; woohoo!

Torinde commented 4 months ago

Great. Can you please add "ZVECTOR" to the z/Architecture line - before merging?