Closed Vrtgs closed 8 months ago
Thanks for the code review, I just don't know how we proceed now
I quite like the changes, nice QOL improvements 👍 .
In general, I would prefer the Deserializer/Serializer to live in the
heap-array
crate since there are more data structure crates then there are encoding crates but since the work is done here already I don't mind merging it. :)
It's fine I moved the Deserializer/Serializer to live in the heap-array
Heya the tests and formating isn't passing yet and would need some fixing before this can be merged, the format is easy just runign cargo format
should do the trick :)
Heya @NightMare-Vortex I updated it to resolve conflicts for the 0.11 release, it'll still need a cargo fmt
run before it can be merged
Heya @NightMare-Vortex are you still interested in finishing this PR?
Heya @NightMare-Vortex are you still interested in finishing this PR?
oh yes I am, sorry I didn't see anything on my email 😅
No worries, I know how easy it is to get flooded with mails :D that's why I figured I'll re-ping every now and then
Attention: 44 lines
in your changes are missing coverage. Please review.
Comparison is base (
b23569d
) 74.85% compared to head (9704530
) 75.94%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As there were a bunch of conflicts I cherry picked the changes and merged them in #72
Alright thanks
although I really do think there should be a discussion about the safety of the parsing code, why is parse fallible, and why we parse the array, without having the values of the array in the first place
Sorry for my shameless dependency plug, btw