simde-utc / portail

Nouvelle API du Portail des Assos de l'UTC
GNU General Public License v3.0
14 stars 8 forks source link

User has to be validated to be shown in API results #324

Closed noeamiot closed 4 years ago

noeamiot commented 4 years ago

This fix is only for when using the route /assos/{asso_id}/members, another fix for the route /user/assos will be necessary (for hiding unvalidated associations from career for example) but will need more time and is not as urgent as this one.

NastuzziSamy commented 4 years ago

Ah ok I see now why you saw this issue as critical.

Actually, it was meant to be like that. The idea here is to show all memberships, asked and confirmed. I implemented a filter for separating the both ones.

I am then closing this and updating your issue related to this PR so we can work on the right issue.

Sorry for not understanding your point at the beginning