simde-utc / utc-mobile

Nouvelle application mobile Portail des Assos - UTC
GNU General Public License v3.0
4 stars 2 forks source link

Clean redux implementation #70

Open r0one opened 5 years ago

r0one commented 5 years ago

Please help me with:

NastuzziSamy commented 5 years ago

I dont get it @CdRom1, what's your problem?

Redux is well implemented and quite customized, in order to auto generate actions and store in a dynamic storage. Check the code, a lot of usage examples are present.

Can you be more explicit in your demand?

r0one commented 5 years ago
NastuzziSamy commented 5 years ago

Ouh sry, wrong repo, redux is not used here, do you think it is usefull to implement redux ?

r0one commented 5 years ago

Well it was supposed to be implemented since the beginning, and redux dependencies are actually loaded. (There is a store implemented in a main file).

We're having a lot of trouble with network I/O, caching, component re-rendering, and other loadings, especially with articles and associations. Some of these troubles include memory leaks, the same resource being reloaded several times, some resources not loaded in time, some optimisations like the order in which articles should be loaded... Implementing redux would help us fix all this issues all at once. But these are minor issues that are visible only on devices with small RAM capacity (>1GB) or whilst using other apps such as web browsers or music players.

Moreover the current style of the code is ok but very heterogenous: interfaces and API calls are initiated with different types of functions : sync or async, with or without arguments, sometimes there are no functions but only properties, sometimes the return type is not predictable... Using the store would help us centralise all those irregularities and help us fix them. And finally, on top of that I think it could even improve performances.

But of course, this issue is not urgent as it doesn't prevent the rest of the app from working.

Romain Maliach-Auguste

On 27 juil. 2019, at 14:30, "Nastuzzi Samy" notifications@github.com wrote:

Ouh sry, wrong repo, redux is not used here, do you think it is usefull to implement redux ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

NastuzziSamy commented 5 years ago

I complelty agree 😊