search

simdjson / simdjson-java

A Java version of simdjson, a high-performance JSON parser utilizing SIMD instructions
Apache License 2.0
266 stars 21 forks source link

Switch to JDK 18 as minumum supported version #29

Closed deejay1 closed 11 months ago

deejay1 commented 11 months ago

Switches to 18 as base release having the minimum supported features. Adds matrix build for JDK versions up to 21.

piotrrzysko commented 11 months ago

Thanks for the PR.

I'm fine with adding Java 21 to the CI, but unless there's a reason to drop support for earlier versions, I'd prefer not to do so. Some users would like to even support Java 17, as mentioned in issue #28.

My suggestion would be to create a separate GitHub job that utilizes Java 21 for building and testing the library. We can set this up using a matrix.

deejay1 commented 11 months ago

Thanks for the PR.

I'm fine with adding Java 21 to the CI, but unless there's a reason to drop support for earlier versions, I'd prefer not to do so. Some users would like to even support Java 17, as mentioned in issue #28.

My suggestion would be to create a separate GitHub job that utilizes Java 21 for building and testing the library. We can set this up using a matrix.

Switched to a matrix build and to 18 as the minimal version with all required features that are used now.

piotrrzysko commented 11 months ago

Looks good. Thanks again!