simdjson / simdjson

Parsing gigabytes of JSON per second : used by Facebook/Meta Velox, the Node.js runtime, ClickHouse, WatermelonDB, Apache Doris, Milvus, StarRocks
https://simdjson.org
Apache License 2.0
19.06k stars 1.01k forks source link

Build failure 0.9.2 on OSX 10.15.7 | Apple clang version 12.0.0 ? #1570

Closed jkhoogland closed 3 years ago

jkhoogland commented 3 years ago

Hi,

I have the following system

OSX 10.15.7
Apple clang version 12.0.0

I pulled the current release 0.9.2 and tried to build the library and tests,

cmake -G "Unix Makefiles" -H. -B_bld -DCMAKE_CXX_STANDARD=14
cmake --build _bld

but get the following compile error:

In file included from /Users/jiri/dev/bb/jmt-dev/jmt/src/lib/3rd/simdjson/simdjson-0.9.2/_bld/benchmark/checkperf-reference/master/src/simdjson.cpp:1:
In file included from /Users/jiri/dev/bb/jmt-dev/jmt/src/lib/3rd/simdjson/simdjson-0.9.2/_bld/benchmark/checkperf-reference/master/include/simdjson.h:38:
In file included from /Users/jiri/dev/bb/jmt-dev/jmt/src/lib/3rd/simdjson/simdjson-0.9.2/_bld/benchmark/checkperf-reference/master/include/simdjson/builtin.h:33:
In file included from /Users/jiri/dev/bb/jmt-dev/jmt/src/lib/3rd/simdjson/simdjson-0.9.2/_bld/benchmark/checkperf-reference/master/include/simdjson/generic/ondemand-inl.h:3:
/Users/jiri/dev/bb/jmt-dev/jmt/src/lib/3rd/simdjson/simdjson-0.9.2/_bld/benchmark/checkperf-reference/master/include/simdjson/generic/ondemand/raw_json_string-inl.h:10:18: error: use of undeclared identifier 'stringparsing'
  uint8_t *end = stringparsing::parse_string(buf, dst);
                 ^

and a lot of similar errors.

From looking at the CMakeLists.txt it was not clear whether I should specify any other parameters ? I must be missing something trivial... Any pointer would be appreciated!

Thanks, Jiri

lemire commented 3 years ago

We changed how the performance checks run which breaks previous builds.

Please do the following:

❯ git clone git@github.com:simdjson/simdjson.git
❯ cd simdjson
❯ git checkout v0.9.2
❯ cmake -DSIMDJSON_JUST_LIBRARY=ON -B build && cmake --build build
lemire commented 3 years ago

You can now just use version v0.9.3 (just released).

jkhoogland commented 3 years ago

great, yep thanks, that works.