simenon / LostTreasure

Lost Treasure is an Elder Scrolls Online addon that shows treasure map and survey locations on your World Map. It includes every known treasure map and survey location.
3 stars 6 forks source link

Replace GetMapTileTexture with GetCurrentMapId #23

Closed aldudko closed 4 years ago

aldudko commented 4 years ago

Using GetCurrentMapId should provide a cleaner way of finding a match between maps and LOST_TREASURE_DATA as GetCurrentMapId doesn't rely on .dds filenames.

simenon commented 4 years ago

In the past it relied on GetCurrentMapZoneIndex() before i switched over on to the texture names, as they are less likely to change. I am not sure on if the GetCurrentMapId() would be reliable if more zones are added.

aldudko commented 4 years ago

There are several exception which need to be hardcoded when using GetMapTileTexture. For example, https://gitter.im/esoui/esoui?at=5dbc5027f26ea4729d368829 Although it doesn't affect LostTreasure right now, because there are no treasure or survey maps in such unconventionally named zones.

As for GetCurrentMapId:

In other words it looks pretty stable to me.

ESO is going to add a new chapter with new zones soon. What do you think about waiting for it so that I can confirm that nothing is broken?

simenon commented 4 years ago

Not relevant anymore