renamed Dist to Distribution for new cp version

simetenn / uncertainpy

Uncertainpy: a Python toolbox for uncertainty quantification and sensitivity analysis, tailored towards computational neuroscience.

http://uncertainpy.readthedocs.io

GNU General Public License v3.0

220 stars 50 forks source link

renamed Dist to Distribution for new cp version #45

Closed coschroeder closed 3 years ago

coschroeder commented 3 years ago

Hi, there is a new chaospy version out. I realized that the "Dist" class is renamed to "Distribution", resulting in errors when running uncertainpy. I only changed it it the parameters.py, nor sure where it is occuring in other places. So I guess an overall compatibility check would also be nice...

Best

simetenn commented 3 years ago

Hi coschroeder,

Thanks for the notification and PR!

cp.Dist is used not used in other places in the library itself, but it is used several places in the tests. Should I update those in this PR, or would you like to do so?

coschroeder commented 3 years ago

please go ahead. you know better which files need changes.

simetenn commented 3 years ago

I moved the PR to a branch with the rest of the changes needed and merged it into that :) I will merge that branch back into master and then create a new release.