Closed james-work-account closed 2 years ago
Name | Link |
---|---|
Latest commit | 960268f80b10ba660af0190b91a68a23bda0fcc6 |
Latest deploy log | https://app.netlify.com/sites/deck-24abcd/deploys/63611f792cc24f000835fd6a |
Deploy Preview | https://deploy-preview-13--deck-24abcd.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
yeah @james-work-account the reason I chose to use pointerup
& blur
and not a simple click-event is because when I was trying to interact (without gyro) by touchmove
on a card, it was registering a click and deselecting the card on every interaction. At least in my emulator and on my S10. I built it without Gyro originally and all the effects were triggered with finger-swipes.
Thanks for raising this and let me check it out on a few devices :)
(I did see it in your previous PR but I left it as I didn't think it was that big of an Issue as the blur
event should handle it. But now I can see it is, hah.)
I think the issue I had may be gone after I changed from touchmove
to pointermove
ah, ok I just tested on an iPhone... seems the iPhone not respecting the blur
event, that's why you can't click off it. Probably something I caused somewhere else in the CSS. But I think this PR is good for now 👍
On iOS, you can open a card but can't close it again. The exception to this is if you open another card - this closes the first card and opens the second, but then there's no way to close the second (without opening a third, etc).
Changing the
on:pointerup
andon:keyup
listeners toon:click
seems to resolve this (aka make it a standard button click listener). I don't know if there was a reason why these other listeners were chosen, hence making this a Draft PR for now, but if this change is okay then I'll open it up.