search

simeydotme / svelte-range-slider-pips

Multi-Thumb, Accessible, Beautiful Range Slider with Pips
https://simeydotme.github.io/svelte-range-slider-pips/
Mozilla Public License 2.0
464 stars 44 forks source link

Fix broken links on docs site #119

Closed sortbyfirstname closed 1 year ago

sortbyfirstname commented 1 year ago

This change fixes some issues with broken links on the docs site, resolving #118.

The pips and range links in the sidebar were not navigating to their respective props in the article because the ids used were also being used in the SVG logo in the site header. When scrolling to fragment it was appearing to do nothing as this is at the top of the page. To resolve this, I have added a 'logo-' prefix to all element ids in all logo SVGs (for consistency).

The links on the Examples & Recipes pages were broken due to the path being incorrect. I have corrected these paths to resolve this.

The broken images on the Recipes page were due to both the way Astro handles public directory images and the way dynamic filename props work in Astro/Vite. The resolution for this is to remove public from the source, replacing with the base (svelte-range-slider-pips), and hardcoding the file extension.

simeydotme commented 1 year ago

Thanks @sortbyfirstname ! I will check this asap

I need to learn what is up with those paths/urls, I was quite new with Astro and I found some weirdness with local/deployed versions myself (re: paths)