search

simeydotme / svelte-range-slider-pips

Multi-Thumb, Accessible, Beautiful Range Slider with Pips
https://simeydotme.github.io/svelte-range-slider-pips/
Mozilla Public License 2.0
434 stars 39 forks source link

[bug] Expected a valid CSS identifier #123

Open djkato opened 7 months ago

djkato commented 7 months ago

Describe the bug node_modules/svelte-range-slider-pips/src/RangeSlider.svelte:686:73 Expected a valid CSS identifier

To Reproduce

create new astro project, install svelte (Installs 5.0.0-next.1), try to use like:

<RangeSlider {max} {min} step="1" pushy={true} values={[50]} />

Screenshots image

simeydotme commented 7 months ago

thanks, when Svelte5 is released, I'll have to look at this :)

serferdinand2 commented 5 months ago

Describe the bug node_modules/svelte-range-slider-pips/src/RangeSlider.svelte:686:73 Expected a valid CSS identifier

To Reproduce

create new astro project, install svelte (Installs 5.0.0-next.1), try to use like:

<RangeSlider {max} {min} step="1" pushy={true} values={[50]} />

Screenshots image

I believe this was fixed in the latest release https://github.com/sveltejs/svelte/releases/tag/svelte%405.0.0-next.38

simeydotme commented 5 months ago

oh it was actually a bug in Svelte, not a design change? :D thanks for sharing that!

serferdinand2 commented 5 months ago

I might be wrong about this but |global has issues in svelte 5. Right now it deletes the whole DOM on global transitions..