search

simeydotme / svelte-range-slider-pips

Multi-Thumb, Accessible, Beautiful Range Slider with Pips
https://simeydotme.github.io/svelte-range-slider-pips/
Mozilla Public License 2.0
464 stars 44 forks source link

Svelte 5 Dependency #155

Closed sst-sat closed 2 weeks ago

sst-sat commented 2 weeks ago

Currently it is not possible (without a workaround) to use this lib in a svelte 5 project.

My current workaround is to add || ^5.0.0-next.0 in my package-lock.json.

simeydotme commented 2 weeks ago

huh?

simeydotme commented 2 weeks ago

it was working before Svelte 5 launched; https://github.com/simeydotme/svelte-range-slider-pips/tree/main/tests/svelte5

simeydotme commented 2 weeks ago

I'll see if their full release broke something, you have any hints / screenshots or error codes to share?

mihrich commented 2 weeks ago

Hi boys!

package.json with latest libs: 

{
  ...
  "devDependencies": {
    "@sveltejs/adapter-auto": "3.3.1",
    "@sveltejs/adapter-node": "5.2.9",
    "@sveltejs/kit": "2.7.3",
    "svelte": "^5.1.6",
    "svelte-range-slider-pips": "^3.1.2"
  }
  ...
}

after npm install command:

2024-10-31_18-43-59

sst-sat commented 2 weeks ago

Same problem like @mihrich .

It works in the test because you are using the code directly without pulling the dependency from npm.

burtonrj commented 2 weeks ago

Having the same issue as @mihrich

@sst-sat would you mind sharing more details RE your workaround? I added || ^5.0.0-next.0 to my package.json file but I'm still getting a dependency error from npm

simeydotme commented 2 weeks ago

thanks for this

Hi boys!

package.json with latest libs:

{
  ...
  "devDependencies": {
    "@sveltejs/adapter-auto": "3.3.1",
    "@sveltejs/adapter-node": "5.2.9",
    "@sveltejs/kit": "2.7.3",
    "svelte": "^5.1.6",
    "svelte-range-slider-pips": "^3.1.2"
  }
  ...
}

after npm install command:

2024-10-31_18-43-59

I'll try to fix it tonight :)

simeydotme commented 2 weeks ago

Currently it is not possible (without a workaround) to use this lib in a svelte 5 project.

My current workaround is to add || ^5.0.0-next.0 in my package-lock.json.

thanks for the issue, should be resolved with 3.1.4 :)

image

https://www.npmjs.com/package/svelte-range-slider-pips/v/3.1.4

simeydotme commented 2 weeks ago

funny, I was using stackblitz / codesandbox to try and verify the fix before publishing ... their default builds for svelte are all having major issues with the same problem but for packages like eslint/prettier haha;

image image image

nightmare, had to basically strip the sandbox back to nothing but sveltekit + range slider