search

simgunz / redshift-plasmoid

Adjusts and configures screen luminosity depending on your surroundings, using Redshift.
http://simgunz.org/projects/redshift-plasmoid/
GNU General Public License v3.0
51 stars 3 forks source link

Missing functionality "Brightness". #2

Closed fightingdreamer closed 12 years ago

fightingdreamer commented 12 years ago

Redshift can change the screen brightness, this patch adds this functionality to the controller and settings dialog.

simgunz commented 12 years ago

I didn't know about this feature. But I don't think this is a necessary feature because the screen brightness can already be setted on demand from the keyboard (in most notebook) or from the battery plasmoid. Moreover from KDE 4.8 all the power settings (brightness included) can be setted on activity basis from the power management module of systemsettings, so there is no need to use redshift to set the brightness. Actually this can conflict with the KDE brightness management if both redshift and KDE change the brightness when an activity is switched. Do you agree?

fightingdreamer commented 12 years ago

Not screen brightness but display(LCD) brightness can be set from KDE power settings, redshift changes only screen(Xorg) brightness.

For example when I set display brightness to 0(from display menu) I don't get black screen, just darker. When I set redshift brightness to 0 I get fully black screen.

Commit gives you option to obtain darker screen, than is possible from the display menu.

This is very useful at night, when you need to work with colors(eg. photo editing), and you can not afford to change the colors correction.