search

simh / simtools

Tools useful when using or migrating to or from a simh simulator environment
48 stars 16 forks source link

Correct argv test #16

Closed stevefalco closed 3 years ago

stevefalco commented 3 years ago

The argv test in tar2mt.c is backwards. The strcmp tests need to look for "== 0" rather than "!= 0".

markpizz commented 3 years ago

Hi Steve,

Thanks for finding this error. I'd just merge your pull request if the commit comment followed the general convention used with the simh and as much as possible with the simtools repos. That would be:

component-affected: First line of commit message < 80 chars
<blank-line if more commit message>
Additional commit comments wrapped < 80

I can cherry pick your commit and do this crediting you as author or you can fix it (unwinding the current commit in your local repo) and then push -f to your github repo.

stevefalco commented 3 years ago

Please go ahead and cherry pick it. If I find anything else, I'll do a better job of following your commit style. :-)

Steve

On Wed, Jan 13, 2021, 8:09 PM Mark Pizzolato notifications@github.com wrote:

Hi Steve,

Thanks for finding this error. I'd just merge your pull request if the commit comment followed the general convention used with the simh and as much as possible with the simtools repos. That would be:

component-affected: First line of commit message < 80 chars

Additional commit comments wrapped < 80 I can cherry pick your commit and do this crediting you as author or you can fix it (unwinding the current commit in your local repo) and then push -f to your github repo. - Mark — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or unsubscribe .
markpizz commented 3 years ago

Cherry Picked

stevefalco commented 3 years ago

Thanks for the cherry-pick. I now see how you want the commit messages to look, and I'll follow that format for any future patches.