search

simh / simtools

Tools useful when using or migrating to or from a simh simulator environment
48 stars 16 forks source link

Eliminate clang warnings when compiling on FreeBSD 10.1R #3

Closed tjmerritt closed 8 years ago

tjmerritt commented 9 years ago

There are a lot of warnings when compiling on FreeBSD 10.1 with clang. I've fixed all but the obsolete tmpnam function warning. Some were fixed by adding -Wno-missing-field-initializers to the Makefiles. The changeset would be much larger if the code itself was fixed. I also commented out the CC=gcc in all of the Makefiles as most contemporary host systems have a gcc compatible C compiler or gcc is the default.

markpizz commented 9 years ago

I keeping with the contributor convention I've followed for the rest of the simh project:

1) Please put your whole name in your GitHub profile. 2) Please contact me offline at mark@infocomm.com with your actual email address.

Thanks.

markpizz commented 9 years ago

Additionally, Commenting out the CC=gcc goes against the general convention already followed in the rest of the simh project. As Tim (who just wrote all these Makefiles) says, make can be invoked with CC=clang or whatever on the command line if someone wants to us a different compiler.

Meanwhile, I'd actually prefer to see changed code which removes warnings rather than changed build commands which masks the potentially useful warnings.

All these warnings are completely expected since no one has done any maintenance on these little things since ~ 2003.