search

simi / omniauth-facebook

Facebook OAuth2 Strategy for OmniAuth
https://simi.github.io/omniauth-facebook/
1.26k stars 403 forks source link

Drop ruby 1.8 support? #145

Closed simi closed 10 years ago

simi commented 10 years ago

@mkdynamic since Ruby 1.8 has not specified hash order (rubyspec) sometimes test for 1.8 are failing due this.

example

Question is if we should prepare test for this or if we can drop Ruby 1.8 since it's not supported anymore.

All we need for drop is to remove it from CI and probably mention it in docs.

mkdynamic commented 10 years ago

Ah, nice catch. My vote would be to fix for 1.8.7 since it seems easy enough to do, and omniauth still targets 1.8.7. If it becomes more of a burden I'd change my opinion and support dropping it.

simi commented 10 years ago

OK, I'm on it.

mkdynamic commented 10 years ago

:+1:

simi commented 10 years ago

Done and we're green again.

Closed via 062d54714838ff692e1a2982e6685ab2a4c19a21.

mkdynamic commented 10 years ago

Woot. Thanks. I totally broke that, I just realized: https://github.com/mkdynamic/omniauth-facebook/commit/cf00da9f8bfb0538f6997335583fc248f7e10648

Sorry :flushed:

simi commented 10 years ago

don't worry :see_no_evil:

simi commented 10 years ago

We're not adventurers like a crodocile dundee to use legacy 1.8 Ruby.

tumblr_mlj4rwmdjp1ry3k4co1_400

Ruby 1.8 hash :arrow_up:

mkdynamic commented 10 years ago

Lol. Totes, those 1.8 unordered hash are so dangerous. :laughing: