simi / omniauth-facebook

Facebook OAuth2 Strategy for OmniAuth
https://simi.github.io/omniauth-facebook/
1.26k stars 404 forks source link

secure_image_url not making any difference #237

Closed MatthewMDavis closed 8 years ago

MatthewMDavis commented 8 years ago

Whether or not I set secure_image_url to true, I get no image and the following warning:

Mixed Content: The page at 'https://fakeapp.herokuapp.com/#' was loaded over HTTPS, but requested an insecure image 'http://graph.facebook.com/10934827019283457/picture'. This content should also be served over HTTPS.

This is running omniauth-facebook v3.0.0 and the Facebook API is v2.6.

mkdynamic commented 8 years ago

@MatthewMDavis Can you paste our OmniAuth config? I cannot reproduce this and the unit test we have overing this suggests the option is used: https://github.com/mkdynamic/omniauth-facebook/blob/master/test/strategy_test.rb#L98

If you are able to write a failing test case, that would be most appreciated.

MatthewMDavis commented 8 years ago

I realized that the Facebook-linked accounts that weren't showing the secure image were accounts created before I had turned that flag on. Deleting the accounts and re-authorizing solved the problem.

On Sun, Jun 26, 2016 at 5:53 PM, Mark Dodwell notifications@github.com wrote:

@MatthewMDavis https://github.com/MatthewMDavis Can you paste our OmniAuth config? I cannot reproduce this and the unit test we have overing this suggests the option is used:

https://github.com/mkdynamic/omniauth-facebook/blob/master/test/strategy_test.rb#L98

If you are able to write a failing test case, that would be most appreciated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mkdynamic/omniauth-facebook/issues/237#issuecomment-228634185, or mute the thread https://github.com/notifications/unsubscribe/ACQ43QI7I5L_h_byYnrLmt6-_D-l37Wsks5qPx8LgaJpZM4IQQh_ .

mkdynamic commented 8 years ago

K, thanks @MatthewMDavis that sounds like the culprit. Closing.