simi / omniauth-facebook

Facebook OAuth2 Strategy for OmniAuth
https://simi.github.io/omniauth-facebook/
1.26k stars 403 forks source link

Remove references to info fields that Facebook no longer returns #311

Closed GUI closed 4 years ago

GUI commented 5 years ago

The following user fields are no longer returned by the Facebook API:

This change took effect for new apps on May 1, 2018, but just started affecting existing apps on January 8, 2019. See the announcement and the changelog.

At least based on what I've found (but I'm not 100% sure), there is no way to get these fields back anymore, so I thought it might make sense to remove them from the docs to avoid confusion.

GUI commented 5 years ago

I thought this issue might also help people that may have been affected by the January 8 change, like our app was. One of our apps had previously been using the verified field in the omniauth callback, which has now disappeared from the response.

So if it helps anyone else affected similarly: From what I can tell, the verified field wasn't probably ever necessary, at least for our use-case. We were just trying to ensure that the e-mail address had been verified, but I believe all the e-mail addresses from Facebook have been verified, so verified only signified an additional level of verification according to the docs:

Someone is considered verified if they take any of the following actions:

  • Register for mobile
  • Confirm their account via SMS
  • Enter a valid credit card
GUI commented 5 years ago

It looks like the Travis CI test failures are specific to Ruby 2.0 and 2.1, and due to RubyGems 3.0 no longer supporting those versions of Ruby, so not necessarily related to these changes. (I could submit a separate PR to try and fix that, but not sure if you want to keep testing in those older versions of Ruby or not.)

simi commented 5 years ago

@GUI please can you provide PR removing those Ruby EOL versions from CI?

github-actions[bot] commented 4 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.