simi / omniauth-facebook

Facebook OAuth2 Strategy for OmniAuth
https://simi.github.io/omniauth-facebook/
1.26k stars 403 forks source link

The Facebook Graph API needs to be upgraded by 28 July #339

Closed madeleinel closed 4 years ago

madeleinel commented 4 years ago

The current Facebook Graph API version (v3.0) is only available until July 28, 2020.

omniauth-facebook should be updated to use Facebook Graph API to 3.1 or above instead.

Thanks!


Version 3.1 Released July 26, 2018 | Available until October 27, 2020

https://developers.facebook.com/docs/graph-api/changelog/version3.1

simi commented 4 years ago

Thanks for noticing this @madeleinel. You can still use newer version https://github.com/simi/omniauth-facebook#api-version. Anyway I think we can bump major version of this gem and update to FB API v4.0 by default. WDYT?

madeleinel commented 4 years ago

That sounds like a good plan to me 🚀 Thanks @simi!

simi commented 4 years ago

Would you mind to prepare pull request for this change @madeleinel? I think you can just follow https://github.com/simi/omniauth-facebook/commit/445d6d6872742eda4d5213d000f0f11d97a5c4e2. Just instead of 2.11 use 3.0 and instead of 3.0 you can use 4.0. New gem version should be 7.0.0.

madeleinel commented 4 years ago

I tried that before I opened the issue, but I didn't have permission to push to the repo. Is there anything I need to do or set up to get push access @simi?

simi commented 4 years ago

@madeleinel you need to fork this reporistory, clone locally, create new branch, commit your changes, push and open pull request

https://opensource.com/article/19/7/create-pull-request-github

Feel free to ping me if you need any additional help.

madeleinel commented 4 years ago

Ah, I'd forgotten about the forking step - thanks!

I've opened a PR for this: #341

olleolleolle commented 4 years ago

@madeleinel Thanks for reporting and repairing this issue! 🎉

simi commented 4 years ago

merged and release, closing

juanibiapina commented 4 years ago

It looks like this is a major version bump without breaking changes for users of this library. Is my understand here correct?

The diff doesn't show any changes in the public API of this gem.

simi commented 4 years ago

Yes, we do major bumps as well when changing default endpoint (default FB API version).