simi / omniauth-facebook

Facebook OAuth2 Strategy for OmniAuth
https://simi.github.io/omniauth-facebook/
1.26k stars 403 forks source link

#343. add access token params in the profile picture url #344

Closed anklos closed 4 years ago

anklos commented 4 years ago

According to new facebook API change, it requires access token to fetch user profile picture: https://developers.facebook.com/docs/graph-api/reference/user/picture/

This pull request adds access token param in the image url, which resolves the issue I posted #343

anklos commented 4 years ago

anyone still maintains this gem?

simi commented 4 years ago

yes, this is on my radar

simi commented 4 years ago

@OlivierJM definitely. I'm just thinking if we should do this only for particular (API) version or just release new major version (of this gem) with API default changed to one related this change is related as well.

OlivierJM commented 4 years ago

I think a release for just this particular API change would do.

tupakapoor commented 4 years ago

Just wanted to leave a gentle reminder that these new requirements go live on Facebook on 10/24 😃

simi commented 4 years ago

OK, let's setup final plan.

Would adding access token for profile picture URL break old APIs?

OlivierJM commented 4 years ago

It doesn't look like It breaks the current APIs

@anklos kindly confirm am not much of a rails guy

anklos commented 4 years ago

@OlivierJM can confirm it does not. I am running my forked version on production.

anklos commented 4 years ago

@simi it does not break old APIs, which just ignore the access_token query params in picture url

OlivierJM commented 4 years ago

awesome, sounds good. what would you recommend we update in the documentation ?

@simi it looks like we are good to go on this.

anklos commented 4 years ago

@OlivierJM could mention that new version supports facebook API changes for profile picture (https://developers.facebook.com/docs/graph-api/reference/user/picture/)

OlivierJM commented 4 years ago

awesome, thanks.

simi commented 4 years ago

released as 8.0.0

OlivierJM commented 4 years ago

Thanks a lot @simi