search

simi / omniauth-facebook

Facebook OAuth2 Strategy for OmniAuth
https://simi.github.io/omniauth-facebook/
1.26k stars 403 forks source link

Change secure_image_url default from false to true #346

Closed swiknaba closed 3 years ago

swiknaba commented 4 years ago

Description

Default secure_image_url to true, see https://github.com/simi/omniauth-facebook/issues/345 for details.

closes https://github.com/simi/omniauth-facebook/issues/345

Notes

As mentioned here https://github.com/simi/omniauth-facebook/issues/343#issuecomment-720614083 you can just turn on the secure_image_url in your settings for now. This PR just aims to change the default value, since it is mandatory. Eventually, in the next major version release, we can drop this option entirely, since there is no point in turning SSL off, if the Facebook API does not support it anymore anyway.

github-actions[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

swiknaba commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@simi any decisions on the merge? With the current default, the gem doesn't work out of the box for new installs :s

simi commented 3 years ago

@swiknaba thanks for this one, it failed out of my radar. Sorry for the delay!