search

simi / omniauth-facebook

Facebook OAuth2 Strategy for OmniAuth
https://simi.github.io/omniauth-facebook/
1.26k stars 403 forks source link

Send appsecret_proof in image_url requests #364

Closed MatMoore closed 3 years ago

MatMoore commented 3 years ago

Hi, this is my first time contributing to this repo so please let me know if I've missed anything.

This PR implements the suggestion in https://github.com/simi/omniauth-facebook/issues/347 to prevent errors like "API calls from the server require an appsecret_proof argument"

Our app has the same problem, since we have configured it to require all requests to include appsecret_proof as described in https://github.com/simi/omniauth-facebook/issues/347#issuecomment-714771108 (this setting is documented in https://developers.facebook.com/docs/graph-api/securing-requests).

We encountered this same error when upgrading to 8.0.0 (due to access token being added to this request) and adding this parameter fixes the problem.

github-actions[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MatMoore commented 3 years ago

hi @simi can you confirm whether this is something you would be interested in merging?

MatMoore commented 3 years ago

Is there a way to reopen this?