search

simiancraft / create-phaser-app

Phaser 3, Webpack 4, Babel 7+boilerplate and a scaffold
https://simiancraft.github.io/create-phaser-app/
Other
373 stars 29 forks source link

test: test clamp branches for linearScale #52

Closed icyJoseph closed 6 years ago

icyJoseph commented 6 years ago

Hi again,

Just adding some branch testing for linearScale.

BR,

J

the-simian commented 6 years ago

hey thanks! I was light on testing so far, so this is handy. I might end up moving this file, but I'll transport the tests with it.

the-simian commented 6 years ago

@icyJoseph Jsut to share some thoughts, I think some more attention to testing will be awesome, I wanted to hit it more aggresively after I added the UI portion, which is coming after this next big Pr, which has been primarily focused on Tiled integration.

icyJoseph commented 6 years ago

@the-simian I think I can set some time apart to write tests. Do you have an idea of what should be covered? If you drop the skeleton of some tests I can go in and complete them.

More Tiled integration sounds awesome, I really like the yarn process-levels command you added.

the-simian commented 6 years ago

@icyJoseph I'll make an issue that will cover testing needs and I'll make sure to tag you.

I've actually added more to the yarn process commands in the next iteration! I haven't got it all hooked up with livereload and all that just yet.