search

simibac / ConfettiSwiftUI

SwiftUI Package for Configurable Confetti Animation 🎉
MIT License
1.71k stars 117 forks source link

repeat configuration #32

Open dimasno1 opened 1 year ago

dimasno1 commented 1 year ago

Repeat configuration is a bit misleading. Seems like 0 repetitions should not produce any confetti? Did I miss something?

Expected Behaviour

code:

.confettiCannon(counter: $counter, repetitions: 3, repetitionInterval: 0.7)

produces 3 repeats

Actual Behaviour

code:

.confettiCannon(counter: $counter, repetitions: 3, repetitionInterval: 0.7)

produces 4 repeats

every time repeats count greater by '1' than expected

Steps to Reproduce the Issue

use any repetitions value in Repeat Configuration and compare with result.

even in README

.confettiCannon(counter: $counter, repetitions: 3, repetitionInterval: 0.7)

produces 4 repeats

Makapre commented 1 year ago

PR is open.