search

similarweb / statusbay-helm

Helm Chart for Statusbay
https://statusbay.io
Apache License 2.0
22 stars 5 forks source link

Fix multiple conditions in if statement #38

Closed aryklein closed 4 years ago

aryklein commented 4 years ago

This change fixes this error:

$ helm install -f values.yaml statusbay .
Error: template: statusbay-helm/templates/watcher/serviceaccount.yaml:1:7: executing "statusbay-helm/templates/watcher/serviceaccount.yaml" at <(.Values.serviceAccount.create) (.Values.watcher.kubernetes.create)>: can't give argument to non-function .Values.serviceAccount.create

This is my Helm version:

$ helm version
version.BuildInfo{Version:"v3.2.0", GitCommit:"e11b7ce3b12db2941e90399e874513fbd24bcb71", GitTreeState:"clean", GoVersion:"go1.14.2"}
aryklein commented 4 years ago

@kaplanelad could you review this PR?

kaplanelad commented 4 years ago

@aryklein sure, sorry for the delay. Thanks for your contribution!

kaplanelad commented 4 years ago

@aryklein, can you please rebase your branch from master?

nicktimko commented 4 years ago

@kaplanelad it looks like @aryklein's branch is rooted on your master; what's the issue? Do you have a local master that isn't pushed up?

image