search

simison / bootstrap3-less

(deprecated) Bootstrap 3 for Meteor, with Less.
60 stars 19 forks source link

Solution: Using this package as a dependency of another package raises error while publishing with meteor #31

Open udondan opened 10 years ago

udondan commented 10 years ago

That's not a problem of this package. I have a package which depends on this one. In one of my less files I @import the variables.import.less file which in the past worked fine with mrt. But now, while publishing the package with meteor, it seems to build the package and then fails because of the missing @import file.

The solution was to make that path available during build time inside of your package directory. You can create a symlink to the packages directory of any random meteor app where the bootstrap3-less package is added. If you don't have such app you could simply create a packages directory and download bootstrap3-less into it.

You might want to make sure to add the packages symlink/folder to your .gitignore file!

@simison Maybe you want to add this info to the readme.

simison commented 10 years ago

Hola amigo! You should head over to @Nemo64's package: https://github.com/Nemo64/meteor-bootstrap which does exactly this.

udondan commented 10 years ago

Hola @simison,

I tried Nemos package. The problem is, I can actually not use it within another package, if the user did not already use Nemos package. Furthermore the user would need to use the exact name custom.bootstrap.json so I can actually include the less files. If the json was named differently, the less file will be named different too and I can't include it... While that's an awesome package, it's not usable inside other modules (yet). I pushed a PR to Nemos package, to get a bit closer but still can not get it working with other packages.

Cheers, Daniel

simison commented 10 years ago

This thing with package requirements & Bootstrap is somewhat annoying with Meteor. When each package requires different Bootstrap package, imagine the amount of duplicate code ending up to browser...

Anyway, it's just silly that /packages isn't public anymore. :-(

@udondan wanna send a PR to update the readme?

udondan commented 10 years ago

This thing with package requirements & Bootstrap is somewhat annoying with Meteor. When each package requires different Bootstrap package, imagine the amount of duplicate code ending up to browser...

Yes, I see that. Though in my case I only need the mixins, not adding the actual css from bootstrap. And that won't work with @Nemo64's package (yet). I hope it will in future.

Anyway, it's just silly that /packages isn't public anymore. :-(

Totally agreed. But as @juliancwirko pointed out in #29 it's possible with this ugly path... see #32.

wanna send a PR to update the readme?

Sure! Let's first see how #32 works. I can't replicate the exact scenario here with a locally cloned package. Want to be sure it works after you merged #32.