search

simjanos-dev / LinguaCafe

LinguaCafe is a self-hosted software that helps language learners read foreign languages.
https://simjanos-dev.github.io/LinguaCafeHome/
GNU General Public License v3.0
888 stars 32 forks source link

fix: language default fonts #330

Closed cblanken closed 3 months ago

cblanken commented 3 months ago

The default font "NotoSans JP" does not render some diacritics very well, in particular, the háček used in several Slavic languages and the acute accent in Greek. The effected languages: Croatian, Czech, Greek, Macedonian, and Slovenian have all been transferred to the "OpenSans" default font group which renders the mentioned diacritics properly.

Font Comparison

NotoSans JP OpenSans
croatian_noto_jp croatian_open_sans
czech_noto_jp czech_open_sans
greek_noto_jp greek_open_sans
macedonian_noto_jp macedonian_open_sans
slovenian_noto_jp slovenian_open_sans
simjanos-dev commented 3 months ago

Wow, thank you so much! Ill check and merge this in tomorrow.

Did you check every language? Im asking because I already have a github issue for it, and if you did, Ill close it.

cblanken commented 3 months ago

All the languages except the ones that require the additional install step. Also Russian which seemed fine. So it's possible Turkish and/or Thai might have issues, but I couldn't actually install Turkish to check in the dev environment. It would just give this error message. image

simjanos-dev commented 3 months ago

Ill check this out too.

simjanos-dev commented 3 months ago

I checked out Turkish, and turns out it is not working: #332

simjanos-dev commented 3 months ago

I checked Ukrainian, it is also fine. I'll check Turkish after it's fixed. I'm 99% sure I checked Thai when I added it, and it is being displayed correctly. I'll close #260.

Thank you so much for this, I really appreciate it!