search

simlist / pyluach

A Python package for manipulating Hebrew (Jewish) calendar dates and Hebrew-Gregorian conversion.
https://github.com/simlist/pyluach
Other
58 stars 8 forks source link

holiday support #5

Closed ofir1023 closed 3 years ago

ofir1023 commented 5 years ago

I would like to have holiday support in this project. The basic support is that if holiday=True, getparash will return the closest parasha or holiday, plus to add the hol-hamo'ed parashos to all parashos. I don't mind contribute it myself, but first I would like to discuss the design with you.

simlist commented 5 years ago

What do you mean Chol Hamoed Parshios? Do you mean the special Torah reading for each day of the holidays?

ofir1023 commented 5 years ago

I meant adding "Hol-hamo'ed Sukot" (and the same for passover) parasha to the parshios list, and return it on the shabbos of hol-hamo'ed.

ofir1023 commented 5 years ago

The way I see it, if you did getparasha (with holiday=True) today (Tuesday of Hol-hamo'ed) you would get "Hol-hamo'ed Sukot", and if you did it on Sunday you would get just 'Sukot' (since that's the closest)

simlist commented 5 years ago

Do you mean returning the holiday of the following Shabbos or of the day of the week given if it's a holiday?

ofir1023 commented 5 years ago

yes. it will just add to the parashos pool also holidays (rosh ha'shana, yom kipur, sukot etc.) and holiday's shabbos.