simmac / threema-msgapi-sdk-java

Gateway MsgApi SDK - Java

https://gateway.threema.ch

Other

1 stars 3 forks source link

Code quality #5

Open simmac opened 8 years ago

simmac commented 8 years ago

From @m007 on March 27, 2015 9:9

Problem

An analysis of the project source with SonarQube (see #1) has also revealed many quality issues with the code.

How to find out

Run a project analysis with SonarQube. A quick view of my analysis:

254 Major Issues untitled

And even 4 Critical Issues untitled1

How to fix

Before adding new features I suggest to first fix about 85% of the found quality issues to ensure that we can call it clean code (at least kind of).

Copied from original issue: threema-ch/threema-msgapi-sdk-java#2

simmac commented 8 years ago

From @micwin on March 31, 2015 9:38

There also are legal issues with a bunch of libraries I don't know. Look at generated maven site, "Project->Dependencies", scroll down to "Licenses"

simmac commented 8 years ago

From @m007 on April 4, 2015 6:54

@micwin see #8

simmac commented 8 years ago

From @micwin on April 4, 2015 17:30

simmac commented 8 years ago

@m007: I just had a look into SonarQube and it indeed shows many issues. The thing is, the majority of real issues comes from the NaCl-library neilalexander/jnacl, so you should look there for improvements. Another big part of the issues shown are conventions (System.out.print for log outputs etc).

But you are right, there still has some work to be done. I fixed very few small issues in commit #7da9286, everyone who want's to contribute, feel free to PR, I will merge everything I think is an improvement. If @threema-ch will merge this into the official code is another question... :neutral_face: