search

simmons / cbm

A Rust library for working with formats found in Commodore Business Machines (CBM) products from the 1980's, including the legendary Commodore 64 home computer.
Apache License 2.0
5 stars 2 forks source link

Address more clippy issues #8

Open simmons opened 1 year ago

simmons commented 1 year ago

Just when you think you've addressed all the clippy issues, they change clippy to find even more issues. :)

This PR should fix all clippy issues as reported by the following version of clippy:

$ cargo clippy --version
clippy 0.1.66 (69f9c33 2022-12-12)
mlund commented 1 year ago

What lint groups are you aiming for? cargo clippy --fix -- -W clippy::pedantic induces quite a few changes, but perhaps that's too, well pedantic?

simmons commented 1 year ago

What lint groups are you aiming for? cargo clippy --fix -- -W clippy::pedantic induces quite a few changes, but perhaps that's too, well pedantic?

So far, I've only been using the default lint groups via cargo clippy. I'm not sure what settings would be considered a best practice.

mlund commented 1 year ago

I'm nor sure either, but pedantic seems a bit much.