simo5 / ietf

0 stars 2 forks source link

Fix nits, clarify shared secret size #19

Closed tomato42 closed 6 years ago

tomato42 commented 6 years ago

fix Nits reported by tools.ietf.org

also clarifies a bit the size of the shared secret negotiated for NIST curves

simo5 commented 6 years ago

Sounds like the three references should not be made informational, I see text in Daniel's Shepherd wrtiteup that indicates those need to be normative even if they are downward references apparently.

Do we need the clarification? Is there any chance an implementor may get those sizes wrong ?

simo5 commented 6 years ago

https://datatracker.ietf.org/doc/draft-ietf-curdle-gss-keyex-sha2/shepherdwriteup/ for reference

tomato42 commented 6 years ago

Do we need the clarification? Is there any chance an implementor may get those sizes wrong ?

that chance is always there, and something like truncation of the shared secret to size of Hash wouldn't be too crazy... so I prefer to be explicit

https://datatracker.ietf.org/doc/draft-ietf-curdle-gss-keyex-sha2/shepherdwriteup/ for reference

I'm really OK either way