search

simoderyouch / moweatherapp

https://moweatherapp.netlify.app/
2 stars 0 forks source link

Do not submit API keys to git #1

Closed dean-leszman closed 1 year ago

dean-leszman commented 1 year ago

Hi, I came across your repo via devchallenges.io.

I notice in your App.js you have an API key for OpenWeatherMap.
This should not be submitted with your source code and should be obtained via environment variables, or other similar alternative.

I appreciate this is most likely an API key on OpenWeatherMap's free tier and is of no real danger to you but such a risk could cause significant problems in the future.

simoderyouch commented 1 year ago

Thanks for bringing this to my attention. I removed the OpenWeatherMap API key from my code and set up an environment variable to store it securely. I appreciate your help in improving the security of my application.

Regards,