search

simogeo / Filemanager

An open-source file manager released under MIT license. Up-to-date for PHP connector. This package is DEPRECATED. Now, please use RichFileManager available at : https://github.com/servocoder/RichFilemanager.
938 stars 350 forks source link

Change duplicate y-acute to y-grave #538

Closed phil-davis closed 6 years ago

phil-davis commented 6 years ago

My IDE told me about this - y-acute is duplicated here. Probably should be y-grave. Noticed in Mautic - PR https://github.com/mautic/mautic/pull/4999

phil-davis commented 6 years ago

Is there any "upstream" of this code somewhere now that this repo is deprecated?

simogeo commented 6 years ago

you can also update RichFilemanager

phil-davis commented 6 years ago

RichFilemanager seems to have a different cleanString that is used by cleanFileName and cleanFileNameDefault and those only substitute a few characters. So I do not see a place where this fix [can|needs to be] applied. https://github.com/servocoder/RichFilemanager/blob/master/connectors/jsp/libraries/java/src/edu/fuberlin/AbstractFM.java

simogeo commented 6 years ago

You're probably right, and @servocoder will confirm this, I guess.

psolom commented 6 years ago

Yeah, it was reworked in RichFilemanager, don't bother yourself with that. @simogeo thanks for the reference to RFM