simogeo / Filemanager

An open-source file manager released under MIT license. Up-to-date for PHP connector. This package is DEPRECATED. Now, please use RichFileManager available at : https://github.com/servocoder/RichFilemanager.
937 stars 350 forks source link

No refresh after delete and rename #88

Closed jicho closed 13 years ago

jicho commented 13 years ago

Hi,

The filemanager works great, but... How can I refresh the info (filetree on the left and the file overview in the main area) after deleting and / or renaming a file?

When I no delete or rename a file nothing happens till I refresh the tree or detail list manual :(

It would be really nice when there is an "auto view update"!

I've tried to find the logic to do this in code, but I can't find is :(

Thnx for your help!

jicho commented 13 years ago

Fixed it :)

It had something to do with the aspx connector: To refresh after delete, rename after the action. Change the following code

retVal = "{ \"Error\":" + EnquoteJSON(error) + "," + " \"Code\":" + code + "," + " \"Old Path\":" + oldPath + "," + " \"Old Name\":" + oldName + "," + " \"New Path\":" + newPath + "," + " \"New Name\":" + newName + "}";

to

retVal = "{ \"Error\":" + EnquoteJSON(error) + "," + " \"Code\":" + code + "," + " \"Old Path\":" + EnquoteJSON(oldPath) + "," + " \"Old Name\":" + EnquoteJSON(oldName) + "," + " \"New Path\":" + EnquoteJSON(newPath) + "," + " \"New Name\":" + EnquoteJSON(newName) + "}";

What is missing EnquoteJSON around the paths. When I did this change it worked for me. Do the same (EnquoteJSON around the paths) for the retVal for Delete function also.

Found it on the forum: http://forum.filemanager.corefive.com/#Topic/18308000000094020

simogeo commented 13 years ago

Hi jicho > aspx connector is not into the trunk. Would you propose a pull ?

Thanks, regards, simon

jicho commented 13 years ago

Hi Simon,

I see what I can do for you. Problem is that the connector is not on GitHub but in a local source system ;) Another thing is that there are some specific CMS / program settings in the connector that making is public would give people a headache to make it work ;)

Funny thing is that I was playing with the idea to publish it on your forum since that's where I've found it. But I wanted to make changes to the settings a little easier first! Big thing is that I first to setup a local working copy of your files with the aspx connector to see if it will work for other users :)

I'll see what I can change with a little help from colleagues coming week and try to publish it on GitHub / send it directly to you to publish it.

Is that an idea?

Greetings

2011/8/19 simogeo < reply@reply.github.com>

Hi jicho > aspx connector is not into the trunk. Would you propose a pull ?

Thanks, regards, simon

Reply to this email directly or view it on GitHub: https://github.com/simogeo/Filemanager/issues/88#issuecomment-1851869

simogeo commented 13 years ago

Eric,

Actually, I think it can't be done without the agreement of the author and I've check the archive, there is no stipulated license. If you feel to contact him to know abour the license and hack is work to integrate it to the trunk of the application, just do it. If not, just forget my proposition. I just thought it would be nice for aspx users (I'm not :p )

jicho commented 13 years ago

Hi Simon,

Toan Nguyen (the original ASPX connector maker) gave me approval to add the aspx connector to the project, so I did (together with some extra stuff). My version also contains a "edit" button to crop images that are shown in a popup and I did some other things like adding the option to upload using "QuickUpload" (but that's ASPX specific).

The stuff in the connector can be made nicer, but I think it's a nice update to the version on the forum.

simogeo commented 13 years ago

Hi Eric,

Thanks for following up the idea. What would be the license? MIT would be a must (since most of the code present here is under MIT). Should be specified into files.

Regarding teh extra features you are talking about, does that mean it is not compatible with core files? I mean index.html file and files loacted under scripts/ folder ?

jicho commented 13 years ago

Hi Simon,

I'm just making a contribution :) I'm nothing thinking in licenses :S I can make it MIT, it seems that I only need to add a little text file to the directories?

The extra feature in filemanager.js is the addition of a "editor" button. It's now on the page without a config setting, but maybe it's best to change the config file so the edit button can be shown using a setting till there is a "Crop" option in the PHP filemanger connector?

There rest of the changes to filemanger.js have no implications to the core :)

simogeo commented 13 years ago

Hi jicho > yoshimido has submitted a ASP.NET connector. Please, see the latest release. An y enhancements welcome!