search

simolus3 / drift

Drift is an easy to use, reactive, typesafe persistence library for Dart & Flutter.
https://drift.simonbinder.eu/
MIT License
2.66k stars 372 forks source link

Incorrect Docomment on InsertMode.select #3248

Closed dickermoshe closed 1 month ago

dickermoshe commented 1 month ago

@simolus3

Pretty sure that this will rollback the entire transaction. Otherwise, insertOrFail is the same as insert. Am I wrong here?

sqlite online repro: link

https://github.com/simolus3/drift/blob/766581369d9bd3088a8795b3f67f54f6f8a57a14/drift/lib/src/runtime/query_builder/statements/insert.dart#L409-L414