search

simolus3 / fluttie

Easily display stunning Lottie animations in flutter apps with this plugin.
Other
453 stars 54 forks source link

Changed every instance of 'resource' to 'asset' as per Flutter's spec. #6

Closed jeroen-meijer closed 6 years ago

jeroen-meijer commented 6 years ago

Hi there,

I noticed your packages uses the word resource where, in the Flutter community, we colloquially refer to these images, fonts and other documents as 'assets'. I've replaced all instances of resource into asset, as using resource could turn out confusing for newcomers to Flutter. I've built the example application, and it builds and runs fine.

NOTE: These changes are breaking for other people's applications that depend on fluttie, but I believe changing this now and informing your users is better for the future. You could alternatively make new methods that use the word asset instead of resource and deprecate the old ones.

I hope you understand and don't mind these changes. If you do, please feel free to message me.

simolus3 commented 6 years ago

Thank you for pointing this out and providing a PR, I appreciate it. I've kept the old method as deprecated for now, I think it makes more sense to remove it in a bigger update.

jeroen-meijer commented 6 years ago

You're welcome, nice work on deprecating it.