simon-budig
commented
3 years ago Thanks for your extensive work.
However, this pull request is just too big and mixes too many issues for it to be manageable. If you're willing to split it up in small commits please do so, because there is good stuff in here.
Other than that I'll try to pick at the individual things this week or so.
Remove EvilZipStreamWraper and therefore closes #3, as it appears to have no use now in Python 3. Zipfile seems to have gotten their act together or something. Change attachment filename to full filename, with compression extensions added by just using location variable defined earlier without the first slash for the server address, closes #4. Additional changes: Make everything use single quotes instead of double quotes unless required because I'm weird like that Add comments to the code for what it's doing to encourage more positive changes Make things use capital letters (may cause bug in the event another piece of software utilizes exact case matching for errors) Make things use f string formatting instead of % formatting almost everywhere, because apparently that might be faster and it looks cleaner Make file opening use context managers unless it doesn't make sense Make most HTML code define meta charset as utf-8 On upload page make it work better for small-screen devices Change FileServHTTPRequestHandler.log_request to use super Make do_POST use a generator for suffix names instead of limiting to 9. Not really needed, but somewhere it might happen Make woof_client use a generator for suffix names instead of limiting to 9 like above