search

simon-budig / woof

an ad-hoc single file webserver
120 stars 17 forks source link

I want to upload multiple files #8

Open thesousou opened 3 years ago

thesousou commented 3 years ago

I'd like to upload multiple files from the "browse" form when using "woof -U".

thesousou commented 3 years ago

@simon-budig , if you're interested by the change, I did a patch that works with minimal changes, and I tested both cases (single file and multiple file upload). Both are working fine on my setup. Please add me to the project, so that I can push the commit and discuss on a review :)

CoolCat467 commented 3 years ago

Just make a pull request man. Adding you to the project would be sketch.

thesousou commented 3 years ago

I'm new to github, and I just read most people make forks to submit PR... ... That's one of the worst process ever! For me a fork is when you disagree with the original repo, and you want to make your own stuff. Cloning the full repo on the server makes no sense. But I'll give it a shot, because I'd like to contribute, and woof was very useful to me.

Roy-Orbison commented 2 years ago

That's one of the worst process ever! For me a fork is when you disagree with the original repo

This is not unique to GitHub, it's the standard method of contributing via Git because it's decentralised. The only difference is an extra "step" of publishing the changes in your local working fork to a public fork, otherwise everyone's local machines would need to be Internet accessible and serve their Git repos 24/7.

Also, multiple uploads is a good feature.