search

simon-dt / gulp-twig

Twig plugin for gulp.js, The streaming build system. Looking for maintainer or collaborators. See wiki
https://github.com/zimmen/gulp-twig/wiki/Looking-for-maintainer-or-collaborator(s)
MIT License
62 stars 33 forks source link

Updated twig.js to 0.8.6 and the version number to 0.3.1 #23

Closed JoelSutherland closed 8 years ago

JoelSutherland commented 8 years ago

I'm using the latest version on a project with no issues.

The tests in the repo error (for me) but it appears to just be a line break issue. The new version is adding '\n' after each line in a way that the test don't like. I'm not sure how to resolve it. I am on Windows so perhaps they would pass without error on unix/OSX.

JoelSutherland commented 8 years ago

Looks like they do pass!

implico commented 8 years ago

So, why don't we merge? :) I extremely need the "embed" tag added in the latest twig.js version...

JoelSutherland commented 8 years ago

I've been using it with the merge and it works great.

On Fri, Jan 15, 2016 at 7:10 AM, Implico notifications@github.com wrote:

So, why don't we merge? :) I extremely need the "embed" tag added in the latest twig.js version...

— Reply to this email directly or view it on GitHub https://github.com/zimmen/gulp-twig/pull/23#issuecomment-171945379.

simon-dt commented 8 years ago

Sorry, I was enjoying some days off but here we go! :-)

implico commented 8 years ago

Nice, thanks:)

simon-dt commented 8 years ago

I did publish it to NPM as version 0.5.0 so you might have to update your dependencies:-)

Op 15 jan. 2016 om 16:59 heeft Implico notifications@github.com het volgende geschreven:

Nice, thanks:)

— Reply to this email directly or view it on GitHub.