search

simon-dt / gulp-twig

Twig plugin for gulp.js, The streaming build system. Looking for maintainer or collaborators. See wiki
https://github.com/zimmen/gulp-twig/wiki/Looking-for-maintainer-or-collaborator(s)
MIT License
62 stars 33 forks source link

update package's node + twigjs versions; update travis's node versions; bump #32

Closed olets closed 7 years ago

olets commented 7 years ago

Updates to the latest twig.js

This PR has gotten bigger. Updated description:

The main purpose of this PR is to use the latest 1.x.y version of twig.js

gulp-twig's node requirements have fallen far enough behind twig.js's that updating to the latest twig.js makes gulp-twig's tests fail. So this PR also updates node in package.json and .travis.yml.

Upping the node version dependency should be considered a breaking change, so I've bumped to v1. This has the perk of fitting nicely with twig.js's versioning. I propose that gulp-twig's major version should always be the same as the major version of the twig.js dependency.

ryuran commented 7 years ago

Twig.js v1.10.4 is released

32 and #34 are exactly for the same thing

olets commented 7 years ago

Sure is! Added 1 to the version specifically so that gulp-twig and anything else that uses twigjs as a dependency can specify semver ranges (which npm doesn't support for v<1.0.0).

Note gulp-twig's tests now fail (#35) but twigjs is passing so this should be safe to merge and use.

ryuran commented 7 years ago

We should change travis config (https://github.com/zimmen/gulp-twig/blob/master/.travis.yml) for recent node/npm. And change node and npm minimal version in package.json. We must up gulp-twig version to indicate new requirement.

olets commented 7 years ago

@ryuran good catch thanks

bezoerb commented 7 years ago

So let's merge this :)

bezoerb commented 7 years ago

@olets, @dotmagic, @webrgp: i think we should consider https://github.com/zimmen/gulp-twig/issues/18, https://github.com/zimmen/gulp-twig/issues/19 and https://github.com/zimmen/gulp-twig/issues/21 before v1.0.0 release. What do you think?

olets commented 7 years ago

I think go with 1.0.0 now. For me, dependencies like this should follow semver - so bumping from 0.x to 1.0 is saying "there was a breaking change" not "we've ironed out the bugs." The upgraded node requirement is a breaking change.

If we do use a lower version, we'll have to remember to downgrade the version in package.json from the bump in f64df15