search

simon-dt / gulp-twig

Twig plugin for gulp.js, The streaming build system. Looking for maintainer or collaborators. See wiki
https://github.com/zimmen/gulp-twig/wiki/Looking-for-maintainer-or-collaborator(s)
MIT License
62 stars 33 forks source link

Add compatibility with gulp-data #8

Closed kara-todd closed 9 years ago

kara-todd commented 9 years ago

I thought it would be nice to add in the ability to pass a gulp-data stream into the twig function rather than having to specify the data in the options.

I took a stab at implementation based on the gulp-data documentation. If this could be integrated, that would be great. Let me know if there are any issues with the PR. :)

simon-dt commented 9 years ago

Hi Kara, thanks for the PR and i'm more than happy to merge this. Since i'm not familiar with gulp-data myself, could you add an example usage in the example folder ? :-)

kara-todd commented 9 years ago

@zimmen I added in an example for usage. It has a requirement for gulp-data (which I didn't add tot he package.json file)

colynb commented 9 years ago

oops, I just submitted a PR for the same thing and included a test. Sorry. Any hope in getting this merged soon?

simon-dt commented 9 years ago

Merged. Sorry for the delay