search

simon-hirsch / rolch

A package for online learning for distributional regression and online models for conditional heteroskedasiticity
https://simon-hirsch.github.io/rolch/
MIT License
9 stars 2 forks source link

Make sklearn optional dependency for the tests in pyproject toml #27

Open simon-hirsch opened 1 month ago

simon-hirsch commented 1 month ago

For running tests we need pytest and sklearn as we test against sklearns implementation of coordinate descent. We should make this explicit in the pyproject.toml.

sklearn has quite a few dependencies and we currently only have it as "soft" dependency for testing (not explicity noted in the pyproject.toml). Allowing for pipelines would be cool though.

_Originally posted by @simon-hirsch in https://github.com/simon-hirsch/rolch/pull/25#discussion_r1768039197_

simon-hirsch commented 1 month ago

Also we might want to check whether we distribute the tests with source :)