simon-r / dr14_t.meter

Compute the DR14 of a given audio file according to the procedure described by the Pleasurize Music Foundation
http://dr14tmeter.sourceforge.net
GNU General Public License v3.0
125 stars 33 forks source link

Does not work on Mac #14

Closed kcramer closed 9 years ago

kcramer commented 11 years ago

The app does not work on a Mac due to an error in audio_file_reader.py. On a Mac, sys.platform returns "darwin" so self.cmd is never set. The __init method just needs to check for the "darwin" return and do the same thing it does for "linux".

You could either include the check in the linux check or add an extra check after line 35:

        elif sys.platform.startswith('darwin'):
            self.__cmd = "%s " % self.get_cmd()
JonnyJD commented 10 years ago

The error mentioned should technically be fixed with 176f6e47b7b977880a8a5c3cf86b88e9945e90ed (in 1.0.13 and later) (fixed with #12)

JonnyJD commented 10 years ago

I also tested this on an OS X VM and it works fine (OS X 10.8, python 2.6 with argparse additionally installed, only tested wav).

simon-r commented 10 years ago

Thanks for your feedback. For the other audio codecs you must install ffmpeg, flac .... .