search

simon-r / dr14_t.meter

Compute the DR14 of a given audio file according to the procedure described by the Pleasurize Music Foundation
http://dr14tmeter.sourceforge.net
GNU General Public License v3.0
125 stars 33 forks source link

Fix --dr_database arg being store_false, not store_true #64

Closed kolen closed 4 years ago

kolen commented 4 years ago

29

-d, --dr_database command-line argument is intended to turn on Loudness War Database compatibility. But it has store_false, inverting its logic (compatibility is turned off when -d specified).

https://github.com/simon-r/dr14_t.meter/blob/ecb431d9a504f9d5d8710303d60ab80a1219ab07/dr14tmeter/parse_args.py#L99-L102

Checked, in master it outputs compatible logs without -d (in compatible logs, title block is single-line, not two lines, one for artist and one for album).

After this patch:

~/items/dr14_t.meter % ./dr14_tmeter -r ~/Music/l/Lacrimosa/1991\ Angst
...

~/items/dr14_t.meter % head -n 6 ~/Music/l/Lacrimosa/1991\ Angst/dr14.txt
----------------------------------------------------------------------------------------------
 Album: Angst
 Artist: Lacrimosa
----------------------------------------------------------------------------------------------
DR  Peak    RMS Duration    Title [codec]
----------------------------------------------------------------------------------------------
~/items/dr14_t.meter % ./dr14_tmeter -d -r ~/Music/l/Lacrimosa/1991\ Angst
...

~/items/dr14_t.meter % head -n 6 ~/Music/l/Lacrimosa/1991\ Angst/dr14.txt
----------------------------------------------------------------------------------------------
 Analyzed: Angst /  Artist: Lacrimosa
----------------------------------------------------------------------------------------------
DR  Peak    RMS Duration    Title [codec]
----------------------------------------------------------------------------------------------
 DR13    -1.37 dB    -17.49 dB  9:25    01 - Seele in Not    [mp3]