search

simon-stahlberg / mimir

GNU General Public License v3.0
13 stars 7 forks source link

`StateSpace.new` silently returns None if `max_expanded` is reached #4

Closed DillonZChen closed 2 months ago

DillonZChen commented 6 months ago

This can happen for example by calling the example script on a problem with a very large state space. A log statement would be nice to detect this.

DillonZChen commented 6 months ago

I just realised that's what the line at 24 in the script does but this does not this never gets called because of line 23.

simon-stahlberg commented 6 months ago

Thank you for your interest and comment. Using state_space before checking was indeed an oversight. :-)

Dominik and I are currently rewriting a large portion of Mimir to improve the interface and produce better error messages. We welcome any feedback. In the next version, we will consider throwing an error instead of returning None, and we will try to use a constructor instead of .new, if possible.