simon-weber / Autoplaylists-for-Google-Music

Adds autoplaylists, aka iTunes "smart playlists", to Google Music.
https://autoplaylists.simon.codes
MIT License
94 stars 18 forks source link

Playlist Not Filling To Desired Amount #185

Closed Noggog closed 6 years ago

Noggog commented 6 years ago

Small issue that I thought I'd bring up:

My playlists seem to not be filling to their desired capacity. I have some simple playlists such as:

The results are as I want them, except it just fills it some smaller amount songs, instead of 900. Seems to be consistently doing so, as well. So far it's been fine since usually it's enough to get me by, but it's curious enough to report.

One of my playlists is filled to 230 right now, while another is about 650. I haven't been able to narrow down a pattern aside from the lists stay at their numbers; I just restarted now and resynced and they stayed at those capacities with different songs.

simon-weber commented 6 years ago

Hm, odd. If the test button is showing the expected result then my guess is the issue is on Google's end (it sounds like what happens when it's overloaded).

Can you try making a copy with the duplicate button, saving that, and then checking if that has the same issue?

Noggog commented 6 years ago

So i made a duplicate, as well as a new playlist:

Hard to see a pattern, other than the duplicate and the new playlist having ~96-97%.

The original seems to be sticking around the 210 area, despite random seed resets (thanks!) and resyncs.

Noggog commented 6 years ago

Another thing I've noticed is the new syncing "progress wave" never finishes. Just stays syncing indefinitely. Not sure if that's an indication of something wrong, or if that's just a GUI event that hasn't been handled so it just shows forever despite actually being complete

vokinpirks commented 6 years ago

liked My playlist Synced 6/18/2018, 7:15:42 PM by Autoplaylists for Google Music™ to contain: (rating equals 5 or rating equals 4 or rating thumb equals "up") sorted by: . 684 songs•89:13:58

Thumbs up Auto-playlist Songs rated with a thumbs up are automatically added to this playlist. 753 songs•98:09:26

753 - 684 = 69 songs are missing

simon-weber commented 6 years ago

Ah, ok, that sounds like classic overloading symptoms to me. Should be able to see if that's the case by turning off periodic syncing for a few days, then coming back and syncing one of the playlists manually.

Another thing I've noticed is the new syncing "progress wave" never finishes

Oops. I hacked that together by waiting for the last sync to register, but forgot to actually do anything when it times out. Easy enough fix.

Noggog commented 6 years ago

I've already got periodic turned off; I usually manually sync every morning when spinning things up.

I'll try doing just one playlist tomorrow and report

Noggog commented 6 years ago

Came in this morning and tried to sync a single playlist. I did this by opening the settings panel, clicking on the single playlist, and hitting save. It did not seem to improve the amount that was put into it: it filled with 205/900.

simon-weber commented 6 years ago

Gotcha. Can you email me your logs after your next sync when you have a chance? I have a feeling they'll just show errors from Google, but it's worth double checking.

Noggog commented 6 years ago

Shipped some logs over. Didn't see any error spam with my quick uneducated glance. The logs didn't seem to save any dropdown data underneath that top layer, so let me know if you want me to drill down and get some of that.

The sync that triggered those logs filled 195/900

Noggog commented 6 years ago

It does give me the feeling that the smaller sizes are systematic or persisted. I've never seen a higher count in recent times on that playlist, and a copy of it immediately has (near) max. I suspect a clone will slowly decrease as its resynced, though, or maybe some event will happen that will cut it down permanently to a low level like the original. That's all just my gut though

simon-weber commented 6 years ago

Hm. Can you try expanding the responses for the line that looks like

finished sync {action: "update", userId: "15722017326388160920", localId: "1489773879742"} . responses (2) [{…}, {…}]

Alternatively you can save the whole request/response from the network tab.

simon-weber commented 6 years ago

I just pushed changes to automatically collect and report the information I was looking for above. If you're still seeing issues, try sending over your logs again: you should see a new "codeCounts" line.

https://github.com/simon-weber/Autoplaylists-for-Google-Music/issues/186#issuecomment-404997520 has more details on the changes.

Noggog commented 6 years ago

Sent another log. I see your codeCounts, which has a response of "TOO_MANY_ITEMS:190, "OK":55

simon-weber commented 6 years ago

Heads up that I'm moving this into a new issue so I can combine multiple threads: #193.